change: Drop Python 3.5 support #542
Conversation
lahirumaramba
changed the title
lahirumaramba
force-pushed
the
lm-drop-py35
branch
from
3d45c1d to
dc8e2cb
Compare
There was a problem hiding this comment.
Looks good. I only had one suggestion.
Have you thought about how to release/version this? In the past we have bumped major version numbers when we discontinued support for a platform version. But GCP is following a more relaxed policy with respect to that (albeit unofficially).
tests/testutils.py
Outdated
| # Fallback for Python 3.5 | ||
| from _pytest.monkeypatch import MonkeyPatch | ||
| return MonkeyPatch() | ||
| return MonkeyPatch() |
There was a problem hiding this comment.
Why not just return pytest.MonkeyPatch()?
There was a problem hiding this comment.
Looks like pytest.MonkeyPatch() works for pytest 6.2 and up. Our CIs use the latest version so I think it would be safe to update this code.
There was a problem hiding this comment.
Should we just set pytest version to 6.2 and up in requirements.txt file?
There was a problem hiding this comment.
Good idea! Updated.
Thanks! I would prefer we do a major version bump to be consistent with our previous releases. Having said that, if we would rather align our releases with GCP policies a minor version bump would not be a big issue. |
Sounds good! Let's do a major version bump for this then. Thanks! |
RELEASE NOTE: Dropped support for Python 3.5. Developers should to use Python 3.6 or higher when deploying the Admin SDK.